Fix GH code review

CGI-FR · Aug 26, 2024 · ceb5b75 · ceb5b75
1 parent 7312f33
commit ceb5b75
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -28,6 +28,15 @@ jobs:
       - id: docker-tag
         uses: yuya-takeyama/docker-tag-from-github-ref-action@v1
 
+      - name: Configure AWS credentials
+        id: aws-credentials
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          # Should use us-east-1 region to push to ECR public registry
+          aws-region: us-east-1
+
       - name: Docker Login to ACR
         # You may pin to the exact commit or the version.
         uses: docker/[email protected]
@@ -36,13 +45,20 @@ jobs:
           username:  ${{ github.actor }}
           password:  ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Login to Amazon ECR
+        id: login-ecr
+        uses: aws-actions/amazon-ecr-login@v2
+        with:
+          registry-type: public
+
       - name: Docker meta
         id: meta
         uses: docker/metadata-action@v5
         with:
           # list of Docker images to use as base name for tags
           images: |
             ${{ env.registry_name }}/${{ github.repository_owner }}/${{ env.image_name }}
+            ${{ steps.login-ecr.outputs.registry }}/cgi-fr/${{ env.image_name }}
           # generate Docker tags based on the following events/attributes
           tags: |
             type=schedule

diff --git a/src/IoTHub.Portal.Server/IoTHub.Portal.Server.csproj b/src/IoTHub.Portal.Server/IoTHub.Portal.Server.csproj
@@ -12,7 +12,7 @@
   </PropertyGroup>
 
   <ProjectExtensions>
-    <VisualStudio><UserProperties properties_4launchsettings_1json__JsonSchema="" /></VisualStudio>
+    <VisualStudio><UserProperties appsettings_1development_1json__JsonSchema="https://cdn.jsdelivr.net/gh/roadrunner-server/roadrunner@latest/schemas/config/2.0.schema.json" properties_4launchsettings_1json__JsonSchema="" /></VisualStudio>
   </ProjectExtensions>
 
   <ItemGroup>

diff --git a/src/IoTHub.Portal.Tests.Unit/Client/Pages/Devices/DevicesListPageTests.cs b/src/IoTHub.Portal.Tests.Unit/Client/Pages/Devices/DevicesListPageTests.cs
@@ -574,7 +574,7 @@ public void SearchDeviceModels_InputExisingDeviceModelName_DeviceModelReturned()
             cut.WaitForAssertion(() => MockRepository.VerifyAll());
         }
 
-        /*[Test]
+        [Test]
         public void ImportDevices_FileAdded_DevicesExported()
         {
             // Arrange
@@ -618,7 +618,7 @@ public void ImportDevices_FileAdded_DevicesExported()
 
             // Assert
             cut.WaitForAssertion(() => MockRepository.VerifyAll());
-        }*/
+        }
 
         [Test]
         public void Sort_ClickOnSortIdAsc_DevicesSorted()