Skip to content

Review after code scanning #4074

Review after code scanning

Review after code scanning #4074

Triggered via pull request December 6, 2024 18:05
Status Success
Total duration 2m 50s
Artifacts 1

ci-tests.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
Unit tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Unit tests: src/IoTHub.Portal.Tests.E2E/Pages/TagsConfigurationPage.cs#L8
Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)
Unit tests: src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L21
Modify 'LoginPage.LoginPage(IConfiguration)' to call 'INavigation.GoToUrl(Uri)' instead of 'INavigation.GoToUrl(string)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2234)
Unit tests: src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L19
In externally visible method 'LoginPage.LoginPage(IConfiguration configuration)', validate parameter 'configuration' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Unit tests: src/IoTHub.Portal.Tests.E2E/Pages/DevicePage.cs#L15
In externally visible method 'DevicePage.DevicePage(IWebDriver driver, WebDriverWait wait)', validate parameter 'wait' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Unit tests: src/IoTHub.Portal.Tests.E2E/Pages/DevicePage.cs#L16
In externally visible method 'DevicePage.DevicePage(IWebDriver driver, WebDriverWait wait)', validate parameter 'driver' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Unit tests: src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L11
Member 'UsernameField' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
Unit tests: src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L12
Member 'PasswordField' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
Unit tests: src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L13
Member 'LoginButton' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
Unit tests: src/IoTHub.Portal.Tests.E2E/Pages/TagsConfigurationPage.cs#L43
Member 'RemoveTag' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
Unit tests: src/IoTHub.Portal.Tests.E2E/E2ETest.cs#L24
Member 'AddBorwserLogs' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
Codecov
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
test-results
847 KB