Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue410: Added groundtruth comparion flags to ./python/TIGRE/algorithms #556

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ameyakhot
Copy link

Submitting my first every PR. Please be free to share feedback if there was anything that needs to be fixed. Thank you for the opportunity.

email: [email protected]

…hms/iterative_recon_alg.py and ./Python/tigre/algorithms/single_pass_algorithms.py
@AnderBiguri
Copy link
Member

Thanks @ameyakhot !

This is a good step towards fixing the issue, but perhaps the issue wasn't clear enough, my bad!

This helps start with it, but now we need to do something with that groundtruth :)

This is related to the Quameasopts variable, that sets the quality measures options. As it is now, each iteration will check the quality measures against the previous iteration. The idea of adding a groundtruth is that when this is given (not otherwise), the quality measures should be compared against the groundtruth, instead of comparing them against the previous iteration.

@ameyakhot
Copy link
Author

I see. So for every iteration, if the Quameasopts variable needs to be compared to groundtruth (if given else None). What actions should be taken if they Quameasopts is equal to groundtruth? Can you share some details?

Thank you for your support.

@AnderBiguri
Copy link
Member

hi @ameyakhot , no not the Quameasopts that is the options variable that is used to control that.

I would suggest having a quick look on how this variable is used in the code. You can also check the MATLAB code (e.g. SART.m) to see how MATLAB handles this.

@ameyakhot
Copy link
Author

Thank you for the explanation @AnderBiguri . I'll take a look for sure at the matlab and see how it works and try to understand what needs to be done in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants