Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Refactoring #52

Closed
wants to merge 23 commits into from

Conversation

chaithyagr
Copy link
Contributor

This PR does code refactoring based on : #36 (comment)

This will be a big PR and is currently under progress. The work will be done by me and @LElgueddari .

Review will be done by @zaccharieramzi . Adding @zaccharieramzi right now to start off review..

@chaithyagr
Copy link
Contributor Author

Yaay!!! Coverage increased to 74 percent! This is awesome. We can cross the 80 percent bar as soon as we get a test with dictionary learning also in place.

@chaithyagr
Copy link
Contributor Author

chaithyagr commented Nov 10, 2019

@LElgueddari can you please add the other calibrationless reconstructions?
I will add an example for self calibrating reconstruction in 2D. You could extend it for other cases that you add.

@chaithyagr
Copy link
Contributor Author

As this PR is very big, we split it up into #53 #54 #55 #57 .
All the above PRs except last one is in at mainline. At this point, this PR (which was kept for backup incase the split up fails), makes no sense.
Closing this here.

@chaithyagr chaithyagr closed this Nov 15, 2019
@chaithyagr chaithyagr deleted the refactoring_movement branch January 13, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants