Created 'Create Section' page, hooked in with real data and added translations #216
Conversation
…ith popover descriptions
jupiter007
requested review from
fraserclark,
andrewebdev and
briri
and removed request for
fraserclark
jupiter007
changed the title
jupiter007
changed the title
| introduction: sectionIntroductionContent, | ||
| requirements: sectionRequirementsContent, | ||
| guidance: sectionGuidanceContent, | ||
| displayOrder: 1, |
There was a problem hiding this comment.
We probably want a way to determine the next number rather than hard coding a 1 here. When a user adds a section in the current tool, it's added at the end instead of the beginning of the list. I'm not sure if we want to continue that in the new tool, but if so we'll want a function to get that number.
There was a problem hiding this comment.
Thanks @briri. That's a good point. It should probably go to the bottom of the list rather than the top. I can make that update and bring it up at Tuesday's meeting to confirm.
There was a problem hiding this comment.
@briri I updated the code to insert the new section with the max displayOrder + 1, so that it will be rendered at the bottom of the list of sections.
components/Editor/index.tsx
Outdated
| const handleChange = (newState: EditorState) => { | ||
| const html = prosemirrorNodeToHtml(newState.doc); | ||
| const handleChange = ((newState: EditorState) => { | ||
| //prosemirror was adding an empty <p></p> when no data was passed, so we need to remove it here |
There was a problem hiding this comment.
How does Prosemirror handle adding blank lines to help separate content? I believe the TinyMCE editor uses empty paragraphs to accomplish this.
We might be better off replacing it only iy what is the entire content of the html.
There was a problem hiding this comment.
@briri, good catch. Prosemirror also inserts <p></p> for additional blank lines. I'll plan on only replacing <p></p> when it is the only content in the field.
There was a problem hiding this comment.
@briri I updated the code to only filter out <p></p> only when that is all that exists in the content.
… updated html filter to filter out <p></p> if there is not text
…e will also need those same interfaces
Description
Created the "Create Section" page, which will be different from "Edit Section" page, primarily because we won't be setting a Section ID until the user successfully creates a new section.
template/[templateId]/section/createinfoto be used next to thetagscomponents/Editor-- updated
components/Editorto use askeletonto display until the editor loads. This became more of a problem as more instances of that DMPEditor were included in the same page.-- switched
components/Editorto use css modules-- added two new props,
errorandidto the componentAddSectionandTagsmutation and queryFixes # (187)
Type of change
How Has This Been Tested?
This was tested both manually and using unit tests.
Checklist:
Screenshots