Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InteractiveSegmentation] Add option to save Segmentation as Dicom #141

Open
ashishsingh18 opened this issue Mar 11, 2020 · 7 comments · May be fixed by #144
Open

[InteractiveSegmentation] Add option to save Segmentation as Dicom #141

ashishsingh18 opened this issue Mar 11, 2020 · 7 comments · May be fixed by #144
Assignees

Comments

@ashishsingh18
Copy link
Collaborator

This will only be enabled if the input was also a Dicom. For Nifti this would simply be unavailable.

@dboun
Copy link
Collaborator

dboun commented Mar 11, 2020

Nice catch!

If you notice, assuming your input image is a dicom:

  • The seeds can be saved as a dicom
  • The output segmentation can't.

So I'm assuming it is properties-related, and I should just copy them

@dboun dboun self-assigned this Mar 11, 2020
@dboun dboun changed the title [Interactive Segmentation] Add option to save Segmentation as Dicom [InteractiveSegmentation] Add option to save Segmentation as Dicom Mar 11, 2020
dboun added a commit to dboun/CaPTk2.0 that referenced this issue Mar 12, 2020
@ashishsingh18
Copy link
Collaborator Author

I will need to see this working. This will be a much bigger fix as the 'save' doesn't give an option to save as dicom.

  1. We will need to add this on the UI. We can start with a button right under the 'Run' that will get enabled if the input was a dicom and if the segmentation completed successfully.

  2. Then we will need to hook it to apt dicom writer with all the meta data from the input dicom.

@dboun
Copy link
Collaborator

dboun commented Mar 12, 2020

Have you seen my PR on this? I think you are overthinking this.

The save context menu option does give an option to save as dicom. To test it, load a dicom image, click create seeds and try to save the seeds

@dboun
Copy link
Collaborator

dboun commented Mar 12, 2020

I should emphasize that in the above it is a requirement that the loaded image is a dicom, eitherwise it is not an option

@ashishsingh18
Copy link
Collaborator Author

Have you seen my PR on this? I think you are overthinking this.

The save context menu option does give an option to save as dicom. To test it, load a dicom image, click create seeds and try to save the seeds

Right you are! I was looking at the incorrect place on older version (2016). Apparently dicom save option is available only when you have a segmentation. If you just load some data and try to save it, there is no option to save as dicom(which makes sense).

@ashishsingh18
Copy link
Collaborator Author

I should emphasize that in the above it is a requirement that the loaded image is a dicom, eitherwise it is not an option

Yes the loaded image should be a dicom. Have you tried it btw with some dicom data?

@dboun
Copy link
Collaborator

dboun commented Mar 12, 2020

Have you tried it btw with some dicom data?

Yes! Before PR #144, only the seeds image could be saved as DICOM. After PR #144 both seeds and output segmentation can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants