Skip to content

Commit

Permalink
Safari doesn't work with path restriction on session ID cookie - so r…
Browse files Browse the repository at this point in the history
…emoving that limit (#150)
  • Loading branch information
daikema authored Jul 17, 2023
1 parent 937cf29 commit 0eeae02
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/auth/oidc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ export async function oidcLoginStart (req: express.Request, res: express.Respons
// Create session key
const sessionId = Array.from({length:32}, (_,i) => urlSafeChars[Math.floor(Math.random() * urlSafeChars.length)]).join("");
res.cookie('sessionId', sessionId, {
path: (new URL(RuntimeConfig.apiAddress + '/auth/oidcCallback', ServerConfig.serverAddress)).href,
maxAge: 600000,
httpOnly: true,
secure: !ServerConfig.httpOnly,
Expand Down

0 comments on commit 0eeae02

Please sign in to comment.