Fix top directory in file browser #1393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluence I started to refactor the code using std::filesystem to resolve a file path and check its type (directory or file), but it became more code maintenance than bug fix and would change many files (look for "exists" in the code!). For this issue, I only fixed the bug, and will refactor in another PR. |
|
I suppose I should also add a test for this bug fix. |
Added FileListTest for default top level folder "/", expect success=true, 0 files, >0 subdirectories. |
|
kswang1029
approved these changes
Dec 10, 2024
kswang1029
added
the
awaiting code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is implemented or fixed? Mention the linked issue(s), if any.
Fixes [file browser] "back to starting directory" button does not work #1394
How does this PR solve the issue? Give a brief summary.
casacore::Path cannot resolve "/" or "/." to absolute path due to parsing error. Instead, use casacore::Path::expandedName() which is used for casacore::File::exists() and casacore::File::isReadable().
Are there any companion PRs (frontend, protobuf)?
No
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
Open file browser and click the top directory of breadcrumbs, which is the root directory. A file list should appear instead of an error.
Checklist
no changelog update neededcorresponding fix added/new e2e test createdprotobuf updated to the latest dev commit/ no protobuf update neededprotobuf version bumped/ protobuf version not bumped