Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warning message from the Xcode compiler #1373

Merged
merged 2 commits into from
May 6, 2024

Conversation

markccchiang
Copy link
Contributor

@markccchiang markccchiang commented Apr 21, 2024

Description

  • What is implemented or fixed? Mention the linked issue(s), if any.
    No specific issue related. This is just a minor code change to fix a warning message from the newer Xcode (15.3) compiler.

  • How does this PR solve the issue? Give a brief summary.
    Explicitly quote the move function from the STL library std::move.

  • Are there any companion PRs (frontend, protobuf)?
    No.

  • Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
    All tests are not affected.

Checklist

  • changelog updated / no changelog update needed
  • e2e test passing / corresponding fix added / new e2e test created
  • ICD test passing / corresponding fix added / new ICD test created
  • protobuf updated to the latest dev commit / no protobuf update needed
  • protobuf version bumped / protobuf version not bumped
  • added reviewers and assignee
  • GitHub Project estimate added

@confluence confluence self-assigned this May 3, 2024
@confluence confluence added the awaiting testing For pull requests that require testing label May 3, 2024
Copy link

github-actions bot commented May 6, 2024

Code Coverage

Package Line Rate Health
src.Cache 72%
src.DataStream 44%
src.FileList 67%
src.Frame 36%
src.HttpServer 42%
src.ImageData 28%
src.ImageFitter 83%
src.ImageGenerators 43%
src.ImageStats 75%
src.Logger 37%
src.Main 52%
src.Region 69%
src.Session 4%
src.Table 52%
src.ThreadingManager 67%
src.Timer 85%
src.Util 40%
Summary 46% (8605 / 18779)

@kswang1029 kswang1029 added awaiting merge For pull requests ready for merge or pending frontend/protobuf changes and removed awaiting testing For pull requests that require testing labels May 6, 2024
@confluence confluence merged commit a97ee32 into dev May 6, 2024
14 checks passed
@confluence confluence deleted the mark/fix_the_warning_from_Xcode branch May 6, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge For pull requests ready for merge or pending frontend/protobuf changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants