-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate fitting results for beam deconvolved images #1364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c78f708.
markccchiang
added
the
requiring frontend
this backend issue requires work in both frontend and backend
label
Apr 8, 2024
…mark/1236_fit_with_beam_deconvolved_images
…mark/1236_fit_with_beam_deconvolved_images
This was referenced Apr 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
Development done but blocked by another issue
requiring frontend
this backend issue requires work in both frontend and backend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is implemented or fixed? Mention the linked issue(s), if any.
Implement Image fitting with beam deconvolved images #1236.
How does this PR solve the issue? Give a brief summary.
Create a class
Deconvolver
which converts the fitting results to beam deconvolved images. The convolution method is originally from thecasacode
.Are there any companion PRs (frontend, protobuf)?
So far no. Question: do we need to create an image for fitting results with beam deconvolution? If so, we may need to modify the frontend and protobuf. We can choose to show both fitting PDF images w and w/o beam deconvolution or there is an option to show only one of them.
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
When fitting with the image that has beam information, the fitting results with beam deconvolution will also shown like the following snapshot:
Checklist
/ no changelog update needed