Angus/hips remote image load #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pford Do you think this is on the right track? this is for loading HIPS files from the hips2fits service using cfitsio's ability to load from URL. Some of the changes are required to avoid opening files multiple times @confluence can we assign this to you or @confluence for cleanup/testing once the frontend is fleshed out? (it's only scripting at the moment) |
pford
added
requiring frontend
12 tasks
|
@pford this PR looks fine to me. Would you turn this as a formal one when you feel ready? |
confluence
reviewed
Jul 4, 2024
confluence
approved these changes
Jul 9, 2024
kswang1029
approved these changes
Jul 14, 2024
acdo2002
approved these changes
Aug 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Load files from the hips2fits server
What is implemented or fixed? Mention the linked issue(s), if any.
Closes Support for loading HiPS FITS images #1379
How does this PR solve the issue? Give a brief summary.
Use CartaFitsLoader to open the file using the URL as the filename.
Are there any companion PRs (frontend, protobuf)?
Angus/remote file requests carta-frontend#2346, Remote file requests from hips2fits server carta-protobuf#93
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
Load HiPS FITS image using the frontend data query UI.
Checklist
no changelog update neededno protobuf update neededprotobuf version not bumped