Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[file browser] "back to starting directory" button does not work #1394

Open
kswang1029 opened this issue Feb 26, 2024 · 3 comments · May be fixed by #1393
Open

[file browser] "back to starting directory" button does not work #1394

kswang1029 opened this issue Feb 26, 2024 · 3 comments · May be fixed by #1393
Assignees
@pford
Labels
bug Something isn't working
Milestone
v5.0-beta

Comments

@kswang1029
Copy link
Contributor

Describe the bug
The "back to starting directory" button does not work in the file browser dialog.

When it is clicked, an error is returned: "Error loading file list for directory"

Screenshot 2024-02-26 at 14 27 06

To Reproduce
Steps to reproduce the behavior:

  1. launch CARTA
  2. click the button to see the error

Expected behavior
When the button is clicked, it should navigate back to the starting directory.

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Ventura
  • Browser [e.g. chrome, safari, electron app]: chrome, electron app
  • Browser version [e.g. 22]: 122
  • Backend branch [e.g. dev, v3b2 release]: dev, v4-stable
  • Frontend branch [e.g. dev, v3b2 release]: dev, v4-stable
@kswang1029 kswang1029 added the bug Something isn't working label Feb 26, 2024
@kswang1029 kswang1029 added this to the v5.0-beta milestone Feb 26, 2024
@kswang1029 kswang1029 mentioned this issue May 14, 2024
Closed
@TienHao
Copy link

TienHao commented Nov 27, 2024

I found the button only not working for "Open Image" and "Import Regions" but still working for "Import Catalog". This should be caused by the fix of CARTAvis/carta-backend/pr/1317, which prevents CARTA.IFileListResponse to retrieve the file list from an empty path (also the starting directory path ""). Perhaps a backend change is needed.

@kswang1029
Copy link
Contributor Author

@pford do you have time to have a look?

@pford
Copy link
Collaborator

pford commented Dec 4, 2024

casacore cannot resolve "/" or "/." (?!). Will rewrite file path resolution code using std::filesystem (was a backend TODO anyway).

@pford pford linked a pull request Dec 6, 2024 that will close this issue
Open
7 tasks
@kswang1029 kswang1029 transferred this issue from CARTAvis/carta-frontend Dec 10, 2024
@kswang1029 kswang1029 assigned pford and unassigned TienHao Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pford pford

Labels
bug Something isn't working
Projects
No open projects
CARTA - frontend
Status: New issues/PRs
Milestone
v5.0-beta
Development

Successfully merging a pull request may close this issue.

Fix top directory in file browser CARTAvis/carta-backend
3 participants
@pford @TienHao @kswang1029