Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICD-RxJS Part 2 migration #56

Merged
merged 102 commits into from
Aug 14, 2024
Merged

ICD-RxJS Part 2 migration #56

merged 102 commits into from
Aug 14, 2024

Conversation

acdo2002
Copy link
Collaborator

@acdo2002 acdo2002 commented Jul 22, 2024

Description

This PR is solved the Issue #3
After this PR, all carta-backend-ICD-tests tests are migrated to the new ICD-RxJS repository.
The current CI/CD github action are written in the carta-backend repository, so adding the tests case into the repository WILL NOT AFFECT the current daily CI/CD.

Already known issue
There is a open regression issue in the carta-backend #1380, the MATCH_STATS_WIDE_BORDERLINE.test.ts may be failed because of the TotalNumber of Region 1. It happens in the Ubuntu 22.04 system. MacOS does not have this problem.
Except this MATCH_STATS_WIDE_BORDERLINE.test.ts, other tests should be ok on my Desktop performance computers (MacOS 13 and Ubuntu 22.04)

Checklist

For the pull request:

  • The Document unchange / Need update the Document
    Notes:
    (1) The corresponding documents have listed in the Issue Migration to RxJS - Part II #3
    (2) MOMENTS_GENERATOR_PROFILE_STREAM.test.ts has been removed because the frontend does not allow generating the moment maps and streaming spectral profile at the same time. (detail documentation)
    (3) IMPORT_MULTIPLE_IMAGE.test.ts has been removed because it duplicates to OPEN_IMAGE_APPEND.test.ts
    (4) FILEINFO* related ICD tests are removed because they become part of unit test in the carta-backend/test/TestFileInfo.cc

ming-yi and others added 30 commits February 7, 2023 18:08
@acdo2002 acdo2002 requested a review from markccchiang July 22, 2024 08:00
@markccchiang
Copy link
Collaborator

Do we need to modify .tests files under ICD_test_stages folder, so the GitHub workflow can include these new tests?

@acdo2002
Copy link
Collaborator Author

@markccchiang I would suggest to measure each part in #3 and know about how long that the server will take. Then you/we can decide which part should be added into the Github workflow.

@acdo2002 acdo2002 merged commit fd26e50 into dev Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants