ICD-RxJS Part 2 migration #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ageController-concurrent.ts
…n ACCESS_CARTA_KNOWN_SESSION.test.ts
…_EXPORT_IMPORT_MATCHING.test.ts
…ONTOUR_CHANGE_SMOOTH_AND_DEMICATION_FACTOR.test.ts
|
Do we need to modify .tests files under |
|
@markccchiang I would suggest to measure each part in #3 and know about how long that the server will take. Then you/we can decide which part should be added into the Github workflow. |
markccchiang
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is solved the Issue #3
After this PR, all carta-backend-ICD-tests tests are migrated to the new ICD-RxJS repository.
The current CI/CD github action are written in the carta-backend repository, so adding the tests case into the repository WILL NOT AFFECT the current daily CI/CD.
Already known issue
There is a open regression issue in the carta-backend #1380, the
MATCH_STATS_WIDE_BORDERLINE.test.tsmay be failed because of the TotalNumber of Region 1. It happens in the Ubuntu 22.04 system. MacOS does not have this problem.Except this
MATCH_STATS_WIDE_BORDERLINE.test.ts, other tests should be ok on my Desktop performance computers (MacOS 13 and Ubuntu 22.04)Checklist
For the pull request:
The Document unchange/ Need update the DocumentNotes:
(1) The corresponding documents have listed in the Issue Migration to RxJS - Part II #3
(2)
MOMENTS_GENERATOR_PROFILE_STREAM.test.tshas been removed because the frontend does not allow generating the moment maps and streaming spectral profile at the same time. (detail documentation)(3)
IMPORT_MULTIPLE_IMAGE.test.tshas been removed because it duplicates toOPEN_IMAGE_APPEND.test.ts(4)
FILEINFO*related ICD tests are removed because they become part of unit test in thecarta-backend/test/TestFileInfo.cc