Merge pull request #11 from CAIDA/leak-communities

Fix memory leak in get_communities_pyset()
CAIDA · Apr 5, 2019 · a743050 · a743050
2 parents 394908e + 8536202
commit a743050
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/_pybgpstream_bgpelem.c b/src/_pybgpstream_bgpelem.c
@@ -82,7 +82,9 @@ static PyObject *get_communities_pyset(bgpstream_community_set_t *communities)
     }
 
     /* add community to set */
-    PySet_Add(set, PYSTR_FROMSTR(comm_buf));
+    PyObject *pystr = PYSTR_FROMSTR(comm_buf);
+    PySet_Add(set, pystr); // does NOT steal reference
+    Py_DECREF(pystr);
   }
   return set;
 }