Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/expand voucher form #2750

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Feature/expand voucher form #2750

merged 6 commits into from
Oct 10, 2024

Conversation

Julian0701
Copy link
Member

DEVELOP

  • 擴充表單欄位
  • 整理資產相關科目、應收付相關科目
  • 新增翻譯

Related Issues

Checklist

  • Used @ in import paths.
  • Verified naming convention compliance (Naming Convention Guidelines).
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 2
    • src/components/voucher/asset_section.tsx
    • src/components/voucher/reverse_section.tsx
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML Diagrams

  • None

Additional Notes

  • Ensured all links are up-to-date.
  • Conducted thorough testing on responsive design changes.
  • Documented any notable considerations or edge cases addressed.

@Julian0701 Julian0701 self-assigned this Oct 9, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 11:51am

@Julian0701 Julian0701 linked an issue Oct 9, 2024 that may be closed by this pull request
[FEATURE] - New Voucher Form 補上漏掉的欄位 #2724
Closed
3 tasks
Luphia
Luphia approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 05c985c into develop Oct 10, 2024
4 checks passed
@Luphia Luphia deleted the feature/expand_voucher_form branch October 10, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@jing12345678910 jing12345678910 Awaiting requested review from jing12345678910

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] - New Voucher Form 補上漏掉的欄位
2 participants
@Julian0701 @Luphia