Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/voucher detail page #2735

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Feature/voucher detail page #2735

merged 5 commits into from
Oct 8, 2024

Conversation

Julian0701
Copy link
Member

DEVELOP

  • Develop Voucher Detail Page
  • IVoucherDetailForFrontend

Related Issues

Checklist

  • Used @ in import paths.
  • Verified naming convention compliance (Naming Convention Guidelines).
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML Diagrams

  • None

Additional Notes

  • Ensured all links are up-to-date.
  • Conducted thorough testing on responsive design changes.
  • Documented any notable considerations or edge cases addressed.

@Julian0701 Julian0701 requested a review from Luphia October 8, 2024 09:42
@Julian0701 Julian0701 self-assigned this Oct 8, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 11:10am

This was linked to issues Oct 8, 2024
[FEATURE] - 整理 IVoucherDetailForFrontend #2734
Closed
[FEATURE] - [UI] Add New Voucher - Voucher detail #2413
Closed
Luphia
Luphia approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 19cde06 into develop Oct 8, 2024
4 checks passed
@Luphia Luphia deleted the feature/voucher_detail_page branch October 8, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] - 整理 IVoucherDetailForFrontend [FEATURE] - [UI] Add New Voucher - Voucher detail
2 participants
@Julian0701 @Luphia