Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate 401 report #2061

Merged
merged 17 commits into from
Aug 21, 2024
Merged

generate 401 report #2061

merged 17 commits into from
Aug 21, 2024

Conversation

jing12345678910
Copy link
Contributor

@jing12345678910 jing12345678910 commented Aug 14, 2024 •
edited
Loading

DEVELOP

  • generate 401 report

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 5
    • src/components/tax_report_body_all/tax_report_body_all.tsx
    • src/pages/users/reports/[reportId]/401-report/index.tsx
    • src/locales/cn/report_401.json
    • src/locales/tw/report_401.json
    • src/locales/en/report_401.json
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

  • None

@jing12345678910 jing12345678910 requested a review from Luphia August 14, 2024 07:13
@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 6:15am

@jing12345678910 jing12345678910 marked this pull request as draft August 14, 2024 07:14
@jing12345678910 jing12345678910 marked this pull request as ready for review August 16, 2024 09:12
This was linked to issues Aug 19, 2024
[FEATURE] - 生成401報表實作 #1430
Closed
[FEATURE] - 401 report concatenation API #2058
Closed
@jing12345678910 jing12345678910 mentioned this pull request Aug 20, 2024
Closed
@jing12345678910 jing12345678910 marked this pull request as draft August 20, 2024 09:56
@jing12345678910 jing12345678910 marked this pull request as ready for review August 21, 2024 02:07
Luphia
Luphia approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 4261dc4 into develop Aug 21, 2024
4 checks passed
@Luphia Luphia deleted the feature/business_tax_return branch August 21, 2024 06:15
@jing12345678910 jing12345678910 linked an issue Aug 26, 2024 that may be closed by this pull request
[FEATURE] - Optimize PR #2061 #2134
Closed
@jing12345678910 jing12345678910 linked an issue Sep 2, 2024 that may be closed by this pull request
[FEATURE] - use translate module on 401 report page #2100
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@jing12345678910 jing12345678910

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jing12345678910 @Luphia