Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/journal-report-trivial-ui #2003

Merged
merged 14 commits into from
Aug 9, 2024
Merged

fix/journal-report-trivial-ui #2003

merged 14 commits into from
Aug 9, 2024

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Aug 9, 2024

DEVELOP

  • feat: validate the fee on the add-journal page when there's change in total price or fee
  • chore: hide missing feat within alpha, adjust the i18n mobile menu, adjust the param for numeric input
  • feat: restrict to upload on add-journal when fee exceeds total price
  • feat: loading skeleton and search string (triggered when btn clicked or enter on keydown) as query for API requests for generated&pending report section on my-reports page
  • feat: disable the filter options on my-reports page when data is loading
  • feat: type enter to trigger api request and disable filters when data is loading on account page for journal list

Related Issues

Checklist

  • Used @ in import paths.
  • Verified naming convention compliance (Naming Convention Guidelines).
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML Diagrams

  • None

Additional Notes

  • Ensured all links are up-to-date.
  • Conducted thorough testing on responsive design changes.
  • Documented any notable considerations or edge cases addressed.

@arealclimber arealclimber self-assigned this Aug 9, 2024
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 11:15am

…or enter on keydown) as query for API requests for generated&pending report section on my-reports page #2004 #1996
@arealclimber arealclimber linked an issue Aug 9, 2024 that may be closed by this pull request
1 task
@arealclimber arealclimber marked this pull request as ready for review August 9, 2024 07:01
@arealclimber arealclimber added this to the v0.8.0 Alpha Release milestone Aug 9, 2024
@arealclimber arealclimber changed the title feat: validate the fee on the add-journal page when there's change in total price or fee fix/journal-report-trivial-ui Aug 9, 2024
@RexBearIU
Copy link
Contributor

Add related issue #2012

@RexBearIU RexBearIU linked an issue Aug 9, 2024 that may be closed by this pull request
@RexBearIU RexBearIU marked this pull request as ready for review August 9, 2024 09:38
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 9fffba3 into develop Aug 9, 2024
4 checks passed
@Luphia Luphia deleted the fix/journal-report-trivial-ui branch August 9, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment