Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/20230215 julian #29

Merged
merged 8 commits into from
Feb 19, 2023
Merged

Feature/20230215 julian #29

merged 8 commits into from
Feb 19, 2023

Conversation

Julian0701
Copy link
Member

DEVELOP

  • Home Page
  • Contact us form
  • Why bolt
  • Usecase list
  • Usecase items

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 5
    • src/components/about/usecase_items.tsx
    • src/components/about/usecase_list.tsx
    • src/components/about/why_bolt.tsx
    • src/components/common/news_items.tsx
    • src/components/common/news_list.tsx
  • new loop: 3
    • src/components/common/news_list.tsx line8 ~ line19
    • src/components/about/usecase_list.tsx line8 ~ line17
    • src/components/about/usecase_items.tsx line15 ~ line17
  • new recursive: 0
  • high risk: 0
  • new sql: 0

@Julian0701 Julian0701 requested a review from Luphia February 15, 2023 10:00
@Julian0701 Julian0701 self-assigned this Feb 15, 2023
This was linked to issues Feb 15, 2023
Contact us form #8
Open
Home Page 完成 #9
Open
Why bolt #22
Closed
Usecase list #23
Open
Usecase items #24
Open
Luphia
Luphia approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 33ffea0 into develop Feb 19, 2023
@Luphia Luphia deleted the feature/20230215_julian branch February 19, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usecase items Usecase list Home Page 完成 Contact us form Why bolt
2 participants
@Julian0701 @Luphia