Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mzhurovich, CC @yarmaksergey,
This
#define
-d symbol fordlib
builds makes it possible to fix OS X builds.Context:
dlib
-based builds.C5T_LOGGER
, it can only be initialized from the "main" process, not from thedlib
itself, while thedlib
should use the passed-in and injected instance ofC5T_LOGGER
.I'll merge this one-liner PR in, and link to the respective fix in the other repo in the comment.
Thx,
Dima