Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the C5T_DLIB symbol. #1004

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

dimacurrentai
Copy link
Contributor

Hi @mzhurovich, CC @yarmaksergey,

This #define-d symbol for dlib builds makes it possible to fix OS X builds.

Context:

  • There were some functions that were not supposed to be called from certain classes when those classes are used from dlib-based builds.
  • For example, with C5T_LOGGER, it can only be initialized from the "main" process, not from the dlib itself, while the dlib should use the passed-in and injected instance of C5T_LOGGER.
  • This worked on Linux so far "just" because that code path was never executed. (And executing it would have been a failure!)
  • OS X is stricter, and this was resulting in linkage errors.
  • With this fix, a clean solution is now possible, implemented, and tested.

I'll merge this one-liner PR in, and link to the respective fix in the other repo in the comment.

Thx,
Dima

@dkorolev dkorolev merged commit 7af4a20 into C5T:stable Jun 27, 2024
4 checks passed
dimacurrentai added a commit to dimacurrentai/c5t_april2024_demo that referenced this pull request Jun 27, 2024
@dimacurrentai
Copy link
Contributor Author

Ref. dkorolev/c5t_april2024_demo#16, specifically the changes in lib_c5t_actor_model.h and lib_c5t_logger.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants