Fixed the WaitableAtomic bug with lack of notifications of updates when updating from Wait() with predicate + mutating "getter".
#1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ait`-originating changes. [ FAILS NOW ]
|
Good, both |
…ve. [ FIXED NOW ]
dimacurrentai
commented
Apr 30, 2024
| std::unique_lock<std::mutex> lock(data_mutex_); | ||
| if (!wait_predicate(data_)) { | ||
| const data_t& data = data_; | ||
| data_condition_variable_.wait(lock, [&wait_predicate, &data] { return wait_predicate(data); }); | ||
| data_condition_variable_.wait(lock, [&wait_predicate, &data]() { return wait_predicate(data); }); |
There was a problem hiding this comment.
CC @mzhurovich @amdrozdov -- I didn't know lambdas can be declared w/o () before, whoa!
|
@mzhurovich ready for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope the first commit fails the tests, and then I push the fix in the second commit.
If this plan does not work out, I'll increase the "delay" and try the "failing" case again.
Fingers crossed!