Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial RFC 5280 test cases #7

Merged
merged 28 commits into from
Jul 11, 2023
Merged

Initial RFC 5280 test cases #7

merged 28 commits into from
Jul 11, 2023

Conversation

woodruffw
Copy link
Collaborator

@woodruffw woodruffw commented Jun 20, 2023 •
edited
Loading

See #1.

@woodruffw
assets: fix issuers
20a0b17 
These were accidentally skipping a level.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw
limbo: begin work on 5280 testcases
da7ea44 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Merge remote-tracking branch 'origin/main' into rfc5280
43d1e41 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw mentioned this pull request Jun 20, 2023
Closed
24 tasks
woodruffw and others added 4 commits June 20, 2023 11:12
@woodruffw
reformat, linting
4e1fa79 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
cleanup
79ec0e5 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
limbo: add a stub webpki mod
01b3544 
Signed-off-by: William Woodruff <[email protected]>
@tnytown
testcases/rfc5280: critical aki, unknown ext
70479da
woodruffw
woodruffw commented Jun 30, 2023
View reviewed changes
limbo/assets.py Outdated Show resolved Hide resolved
woodruffw
woodruffw commented Jun 30, 2023
View reviewed changes
limbo/testcases/rfc5280.py Outdated Show resolved Hide resolved
woodruffw
woodruffw commented Jul 6, 2023
View reviewed changes
limbo/testcases/webpki.py Outdated Show resolved Hide resolved
tnytown and others added 8 commits July 7, 2023 10:43
@tnytown tnytown marked this pull request as ready for review July 10, 2023 20:19
woodruffw
woodruffw commented Jul 10, 2023
View reviewed changes
assets/cryptography.io.cer Outdated Show resolved Hide resolved
woodruffw
woodruffw commented Jul 11, 2023
View reviewed changes
assets/cryptography.io.pem Outdated Show resolved Hide resolved
woodruffw
woodruffw commented Jul 11, 2023
View reviewed changes
limbo/assets.py Outdated Show resolved Hide resolved
@woodruffw
Copy link
Collaborator Author

LGTM! We'll probably want to think about convenience APIs for pre-baked assets in the future, but this is all we need for now.

@woodruffw woodruffw merged commit 6182708 into main Jul 11, 2023
@woodruffw woodruffw deleted the rfc5280 branch July 11, 2023 19:16
@woodruffw
Copy link
Collaborator Author

Nice work @tnytown!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnytown tnytown tnytown left review comments

Assignees

@woodruffw woodruffw

@tnytown tnytown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodruffw @tnytown