Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple delimiters #1055

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

willm
Copy link

@willm willm commented Nov 16, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Have you added tests for the new feature
  2. Does your submission pass tests?
  3. Have you lint your code locally prior to submission?
  4. Have you updated the docs?
    • If you added new parsing or formatting options have you added them to the docs?
    • If applicable have you added an example to the parsing or formatting docs?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@c2fo-cibot c2fo-cibot bot added the size/M Denotes a PR that changes 30-99 lines label Nov 16, 2024
@willm
Copy link
Author

willm commented Nov 16, 2024

Addresses #1054

@juanri0s
Copy link
Contributor

juanri0s commented Nov 21, 2024

@willm looks like CI tests are failing. Mind reviewing them? The suite was having issues before so it probably wasn't caught when you opened the PR.

@willm willm force-pushed the feature/multiple-delimiters branch from e82642c to dcad5ab Compare November 21, 2024 08:19
@willm
Copy link
Author

willm commented Nov 21, 2024

@juanri0s The issue #102 test was flaky due to not always completing in jest's default 5 second timeout, I increased the test timeout to 7 seconds. I hope this is acceptable, I'm pretty sure this was intermittently failing before my changes.

@willm willm force-pushed the feature/multiple-delimiters branch from dcad5ab to 87c4c84 Compare November 24, 2024 19:57
@willm willm force-pushed the feature/multiple-delimiters branch from 87c4c84 to db89b95 Compare November 30, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants