Remove lodash.isequal in favor of built-in array method

C2FO · Oct 22, 2024 · 35e6197 · 35e6197
1 parent 1b206dd
commit 35e6197
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 22 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/format/package.json b/packages/format/package.json
@@ -39,14 +39,12 @@
     "dependencies": {
         "lodash.escaperegexp": "^4.1.2",
         "lodash.isboolean": "^3.0.3",
-        "lodash.isequal": "^4.5.0",
         "lodash.isfunction": "^3.0.9",
         "lodash.isnil": "^4.0.0"
     },
     "devDependencies": {
         "@types/lodash.escaperegexp": "4.1.9",
         "@types/lodash.isboolean": "3.0.9",
-        "@types/lodash.isequal": "4.5.8",
         "@types/lodash.isfunction": "3.0.9",
         "@types/lodash.isnil": "4.0.9",
         "@types/node": "^20.10.5"

diff --git a/packages/format/src/formatter/RowFormatter.ts b/packages/format/src/formatter/RowFormatter.ts
@@ -1,5 +1,4 @@
 import isFunction from 'lodash.isfunction';
-import isEqual from 'lodash.isequal';
 import { FormatterOptions } from '../FormatterOptions';
 import { FieldFormatter } from './FieldFormatter';
 import { isSyncTransform, Row, RowArray, RowHashArray, RowTransformCallback, RowTransformFunction } from '../types';
@@ -145,7 +144,10 @@ export class RowFormatter<I extends Row, O extends Row> {
             return { shouldFormatColumns: true, headers: null };
         }
         // if the row is equal to headers dont format
-        return { shouldFormatColumns: !isEqual(headers, row), headers };
+        if (Array.isArray(row) && headers.every((header, i): boolean => header === row[i])) {
+            return { shouldFormatColumns: false, headers };
+        }
+        return { shouldFormatColumns: true, headers };
     }
 
     // todo change this method to unknown[]