-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update search, so it works with the new after
syntax.
#456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging to
|
brili
previously approved these changes
May 16, 2024
@InnocentBug thanks for pointing out the dupes issue, its an easy fix. |
brili
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated search URL generation.
It now works with
Changes
Some updates to the paginator interface that enables partial searches, that allows interrupted searches for the SDK as well.
Known Issues
Many entries on
stage
are invalid.So we had to work around this in the tests.
Ideally we don't have to do that.
@brili
I noticed, that BigSMILES search does not deliver 10 nodes by default. It is 1 node for me.
@brili
Also it appears that the
after
method returns some nodes multiple times.I get the same UUID in the search results, I don't think that is as it should be.
Notes
Checklist
CONTRIBUTORS.md
) in the pull request source branch.