Fix uid cycle deserialization #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
InnocentBug
added a commit
that referenced
this pull request
Mar 14, 2024
* add untested iterator functionality * add alphabetical order * strictly enforce that UUID is a str * right order of decorators * fix deepcopy problem * Fix uid cycle deserialization (#442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some JSON with cycles broken by UID couldn't be deserialized because the order of UID was not good for the JSON module.
Changes
Store a temporary UIDProxy element if a UID can't be resolved.
After reading in with
load_nodes_from_jsonthe proxies are replaced by the nodes if possible.The type declaration was fixed to nodes before, now UIDProxy objects are permissible.
Known Issues
For the implementation of the Node type hint that is equivalent to
Union[Node, UIDProxy]internal implementations of thetypingmodule are used.Notes
Checklist
CONTRIBUTORS.md) in the pull request source branch.