Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iterators for UUID nodes #439

Merged
merged 14 commits into from
Mar 14, 2024
Merged

Add iterators for UUID nodes #439

merged 14 commits into from
Mar 14, 2024

Conversation

InnocentBug
Copy link
Collaborator

@InnocentBug InnocentBug commented Mar 11, 2024

Description

Add iterator capability for UUID nodes.

Changes

UUID attributes are strictly strings now.

Known Issues

Notes

Let's add some test to ensure iteration over nodes is dfs, and we need to tests this with a graph that contains cycles.

Checklist

  • [ x] My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • [ x] I have updated the documentation to reflect my changes.
  • [ x] My code changes have been verified by automated tests and pass all relevant test scenarios.

@InnocentBug InnocentBug requested a review from duboyal March 11, 2024 21:25
@InnocentBug InnocentBug self-assigned this Mar 11, 2024
Copy link

trunk-io bot commented Mar 11, 2024

🚫 This pull request was closed and has been removed from the merge queue (details).

@InnocentBug
Copy link
Collaborator Author

@duboyal please add tests to this as discussed.
Even if the tests don't work, no worries just add them anyways, and I can debug.

@InnocentBug InnocentBug force-pushed the iterator branch 2 times, most recently from 0015b99 to 82a6882 Compare March 11, 2024 22:13
duboyal
duboyal previously approved these changes Mar 12, 2024
@InnocentBug
Copy link
Collaborator Author

we can't merge it yet, since it is untested

@InnocentBug InnocentBug requested a review from duboyal March 12, 2024 23:09
@InnocentBug InnocentBug marked this pull request as ready for review March 12, 2024 23:09
@InnocentBug
Copy link
Collaborator Author

I think the tests show green now.

duboyal
duboyal previously approved these changes Mar 13, 2024
@InnocentBug
Copy link
Collaborator Author

/trunk merge

@InnocentBug InnocentBug merged commit 74104b1 into develop Mar 14, 2024
13 checks passed
@InnocentBug InnocentBug deleted the iterator branch March 14, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants