Keep alive #432
Merged
Keep alive #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
duboyal
reviewed
Feb 28, 2024
src/cript/api/api.py
Outdated
| self._api_request_session = requests.Session() | ||
| # add Bearer to token for HTTP requests | ||
| self._api_request_session.headers = {"Authorization": f"Bearer {self._api_token}", "Content-Type": "application/json"} | ||
|
|
duboyal
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements the use of a
sessionobject for connecting with the API.This should stream line better if a large number of requests is made.
With the capsulated requests and the previous
connectanddisconnectmethods this is really easy to implement.Changes
Known Issues
Unfortunately, it does not resolve the problems, we have with bigsmiles search.
Notes
Merge after #430 and #431.
Checklist
CONTRIBUTORS.md) in the pull request source branch.