Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for find children method #419

Merged
merged 11 commits into from
Nov 25, 2023
Merged

Docs for find children method #419

merged 11 commits into from
Nov 25, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Nov 22, 2023

Description

wrote documentation for Base.find_children()

Changes

  • wrote docs
  • added numpy documentation sections
    • wrote documentation for the attributes, return type, and notes
  • wrote clear example code that supports doctest
  • added type hinting where needed

Screenshots

Base find_children docs

Known Issues

Notes

The documentation is a bit long, but I don't know how to make it shorter without making it harder to understand. I think it might be okay for now.

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.
  • My code changes have been verified by automated tests and pass all relevant test scenarios.

* wrote parameters docs in numpy with typing and explanation
* added return type
* wrote clear example with doctest
* working on note section to be easy to understand and easy to read with good UI and UX
Copy link

trunk-io bot commented Nov 22, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916 nh916 requested a review from InnocentBug November 22, 2023 20:29
@nh916 nh916 merged commit 4071fbb into develop Nov 25, 2023
13 checks passed
@nh916 nh916 deleted the docs_for_find_children_method branch November 25, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants