added a flag for if the file is a local path or not #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changed property setter to a method setter * setter takes `new_source` and a boolean flag of if the file is local or not * changed constructor to require boolean flag of `is_file_source_local_path` * wrote `set_file_source()` docstring sna documentation * updated source property docstrings documentation to reflect the new changes * changed `_upload_file_and_get_object_name` to work with boolean flag * removed redundant check on it * changed is statement check on `ensure_uploaded()` to work with boolean flag
|
Merging to
|
…`is_file_source_local_path`
….File boolean flag
|
@InnocentBug can't add boolean flag for we could only have it as a setter though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added a flag for if the file is a local path or not
Changes
new_sourceand a boolean flag of if the file is local or notis_file_source_local_pathset_file_source()docstring sna documentation_upload_file_and_get_object_nameto work with boolean flagensure_uploaded()to work with boolean flagis_file_source_local_pathis_file_source_local_pathKnown Issues
Notes
Checklist
CONTRIBUTORS.md) in the pull request source branch.