added has_db_schema_validation flag
#364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
|
I don't love this implementation because it is either validating everything or nothing, but I think this is just a stepping stone for us to then use it in the next parts of the SDK and allow for turning OFF of some db schema validations and leave the essential ones ON |
InnocentBug
requested changes
Sep 27, 2023
src/cript/api/api.py
Outdated
| @@ -603,7 +604,7 @@ def _get_db_schema(self) -> dict: | |||
| @beartype | |||
| def _is_node_schema_valid(self, node_json: str, is_patch: bool = False) -> bool: | |||
There was a problem hiding this comment.
I would write a force_schema_validation argument into this function.
This way, there is a way to force the validation.
And the we can force this validation in api._internal_save.
That looks like the best solution to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a flag to the entire class that can enable or disable the db schema validation
Changes
Tests
Known Issues
Notes
@InnocentBug not sure if we need the flag added to the whole class or if we can just put it on the method instead as a parameter.
I think passing it as an argument is more preferable because it avoids the bulk, and encapsulates everything just in the method.
Checklist
CONTRIBUTORS.md) in the pull request source branch.