Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: created API.delete_node_by_uuid(node_type, node_uuid) #353

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Sep 18, 2023

Description

wrote new API method delete_node_by_uuid

Changes

  • wrote new API method, delete_node_by_uuid
  • wrote documentation for delete_node_by_uuid
  • changed api.delete() to call delete_node_by_uuid under the hood
  • updated api.delete documentation

Screenshots

click to see `cript.API` documentation with new changes

image

Tests

  • ran integration tests and it is working fine

Known Issues

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

* wrote documentation for `delete_node_by_uuid`
* changed `api.delete()` to call `delete_node_by_uuid` under the hood
* updated `api.delete` documentation
@trunk-io
Copy link

trunk-io bot commented Sep 18, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916 nh916 requested review from InnocentBug and removed request for InnocentBug September 18, 2023 22:30
@nh916 nh916 requested a review from InnocentBug September 18, 2023 22:50
@nh916 nh916 changed the title feature: created delete_node_by_uuid Feature: created delete_node_by_uuid Sep 19, 2023
@nh916 nh916 added the enhancement New feature or request label Sep 19, 2023
@nh916 nh916 changed the title Feature: created delete_node_by_uuid Feature: created cript.API.delete_node_by_uuid(node_type, node_uuid) Sep 19, 2023
@nh916 nh916 changed the title Feature: created cript.API.delete_node_by_uuid(node_type, node_uuid) Feature: created API.delete_node_by_uuid(node_type, node_uuid) Sep 19, 2023
@nh916 nh916 merged commit 917126c into develop Sep 19, 2023
12 checks passed
@nh916 nh916 deleted the feature-delete_node_by_uuid branch September 19, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants