Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade requirements_docs.txt #350

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Upgrade requirements_docs.txt #350

merged 2 commits into from
Sep 15, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Sep 15, 2023

Description

Upgrade requirements_docs.txt

Changes

Tests

Known Issues

Notes

requirements_dev.txt needed upgrades, but not sure if we want to change our syntax from >= to ==
image


  • mkdocs 9.3 dropped support for Python 3.7
  • pymdown-extensions 10.3 dropped support for Python 3.7

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

@trunk-io
Copy link

trunk-io bot commented Sep 15, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916
Copy link
Contributor Author

nh916 commented Sep 15, 2023

seeing how all the packages that we are using are dropping support for Python 3.7, I strongly recommend we do the same, we don't currently have anyone that requires Python 3.7 for their work

@nh916 nh916 requested a review from InnocentBug September 15, 2023 20:57
@nh916 nh916 enabled auto-merge September 15, 2023 20:59
@InnocentBug
Copy link
Collaborator

we don't currently have anyone that requires Python 3.7 for their work

we don't know our users, so how can we know?

@nh916
Copy link
Contributor Author

nh916 commented Sep 15, 2023

we don't currently have anyone that requires Python 3.7 for their work

we don't know our users, so how can we know?

Currently, Sarah appears to be the sole user of the SDK, and she has transitioned to Python 3.8+. Users on Python 3.7 would probably upgrade given that many other packages now require 3.8+. If they have any concerns, they can reach out to us via our discussions or other means. We'll either assist them directly or we'll reconsider certain updates based on their feedback.

@nh916 nh916 added this pull request to the merge queue Sep 15, 2023
@nh916 nh916 removed this pull request from the merge queue due to the queue being cleared Sep 15, 2023
@nh916 nh916 changed the title Upgrade requirements_docs.txt Upgrade requirements_docs.txt Sep 15, 2023
@nh916 nh916 merged commit bd0ec37 into develop Sep 15, 2023
12 checks passed
@nh916 nh916 deleted the upgrade-requirements branch September 15, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants