Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove brittle dep test #336

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Remove brittle dep test #336

merged 1 commit into from
Sep 12, 2023

Conversation

InnocentBug
Copy link
Collaborator

Description

This test has been failing for a while and doesn't contribute much confidence.
When we have time to figure it out, we can reintroduce it.

Changes

Tests

Known Issues

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

@InnocentBug InnocentBug requested a review from nh916 September 12, 2023 12:22
@trunk-io
Copy link

trunk-io bot commented Sep 12, 2023

🚫 This pull request was closed and has been removed from the merge queue (details).

@InnocentBug InnocentBug changed the base branch from main to develop September 12, 2023 12:22
@nh916
Copy link
Contributor

nh916 commented Sep 12, 2023

yeah I was thinking of removing it too for now, I agree

@InnocentBug InnocentBug merged commit 5a41a78 into develop Sep 12, 2023
10 checks passed
@InnocentBug InnocentBug deleted the remove-brittle-dep-test branch September 12, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants