Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created complex_local_file_node fixture for easy testing for future #329

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Sep 7, 2023

Description

created complex_local_file_node fixture for easy testing for future

Changes

  • added notes attribute to already existing complex_file_node
  • added complex_local_file_node fixture
    • this comes in handy during integration tests or during tests where we want to swap out the file node really quickly to see if the issue is the file node having a local source or a web source

Tests

Known Issues

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

@trunk-io
Copy link

trunk-io bot commented Sep 7, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916 nh916 requested a review from InnocentBug September 7, 2023 20:49
@nh916 nh916 merged commit 9236fe5 into develop Sep 11, 2023
14 checks passed
@InnocentBug InnocentBug deleted the created-local-file-fixture branch March 27, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants