Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added log for file uploads #322

Merged
merged 1 commit into from
Sep 6, 2023
Merged

added log for file uploads #322

merged 1 commit into from
Sep 6, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Sep 6, 2023

Description

The user is often unsure if the SDK uploaded their file to AWS S3 or not, so I added a log to the terminal that tells the user when their file was uploaded to S3.

Changes

  • added a log after upload to s3

Screenshot

The output looks like this
image

Known Issues

  • the terminal output is a bit too long, but I was unsure of how else to write it

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

@trunk-io
Copy link

trunk-io bot commented Sep 6, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916 nh916 requested a review from InnocentBug September 6, 2023 19:32
@nh916 nh916 merged commit 35505b8 into develop Sep 6, 2023
14 checks passed
@nh916 nh916 deleted the log-file-uploads branch September 6, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants