Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: putting Data node example code above #319

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Sep 6, 2023

Description

Moving the example code for creating Data node above the Parameter and Returns section in under the constructor

Changes

Screenshot

image

Tests

Known Issues

  • the ordering between all the nodes I think is inconsistent because each one is in a different order
    • this would not change the overall documentation, its usefulness, but lessens its perfection
  • the ordering goes against Numpy style guide ideal order, but I think it is okay because
    1. we are not currently following the ideal order anywhere else
    2. it looks nicer and has better UI/UX for the user

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

@trunk-io
Copy link

trunk-io bot commented Sep 6, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916 nh916 requested a review from InnocentBug September 6, 2023 17:10
@nh916 nh916 merged commit 7dc567c into develop Sep 6, 2023
14 checks passed
@nh916 nh916 deleted the update-data-docs branch September 6, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants