Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release CRIPT Python SDK v2.1.0 #315

Merged
merged 0 commits into from
Sep 11, 2023
Merged

Release CRIPT Python SDK v2.1.0 #315

merged 0 commits into from
Sep 11, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Sep 1, 2023

Description

Python SDK is ready for release v2.1.0

Changes

  • delete
    • with documentation
    • with integration tests
  • updated/upgraded documentation for every node
    • fixed some outdated code examples
    • fixed issues with attributes tables
    • fixed broken links
  • update requirement packages
  • upgraded error messages and better error handling for many requests
  • added bigsmiles search to SDK
  • fixed static type errors found with mypy
  • added CRIPT USA Availability in documentation and repository
  • refactored cript.Material attribute from identifiers to identifier
    • updated all tests and documentation along with it
  • resolved trunk cspell spell check issues

Notes

Credits

@InnocentBug

@trunk-io
Copy link

trunk-io bot commented Sep 1, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

InnocentBug
InnocentBug previously approved these changes Sep 6, 2023
@InnocentBug
Copy link
Collaborator

I think you will have to do this manually outside of Github.
Force push this branch as main.

@nh916
Copy link
Contributor Author

nh916 commented Sep 11, 2023

I think for this release what I'll have to do for this release is

Force Push Develop Onto Main

git checkout develop
git push origin develop:main --force     # force push develop onto main

Refresh Main From Repo

git branch -d main   # delete the local main branch
git fetch origin     # fetch the latest branches from remote
git checkout main    # checkout the new main which is now the same as develop

This is because I made a mistake last time and squash & merged the PRs from develop into main instead of a regular merge.

I looked into merge strategies for each branch to see if we can disable squash & merge for main branch, but I don't think that feature exists yet, but a lot of people seem to want it though.

https://github.com/orgs/community/discussions/10809


After develop is force pushed onto main, I will go ahead and make an announcement on the repo

  1. whoever that has a copy of the SDK to be sure to delete their local branch and pull it again
  2. that the SDK has a new release out

@nh916 nh916 requested a review from InnocentBug September 11, 2023 18:08
@nh916
Copy link
Contributor Author

nh916 commented Sep 11, 2023

out of an abundance of caution I am waiting for a PR approval before force pushing develop to main

Copy link
Collaborator

@InnocentBug InnocentBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is a little odd.
It almost looks like this is competely new code.
Its more like as if we merge against a deleted branch.

Its hard to review, but it looks fine to me.

@nh916
Copy link
Contributor Author

nh916 commented Sep 11, 2023

Something is a little odd. It almost looks like this is competely new code. Its more like as if we merge against a deleted branch.

Its hard to review, but it looks fine to me.

yeah I agree, I saw the same thing. It was my mistake for doing squash & merge between develop and main in the first release. I'll add that to our internal wiki to always do a regular merge between develop and main and never do a squash and merge because it'll create merge conflicts.

maybe it thinks that since it only has a single commit and doesn't have all of those they are different

@nh916
Copy link
Contributor Author

nh916 commented Sep 11, 2023

since we are force pushing and it is a bit dangerous, I'll keep a fork backup of the SDK, that we can use just in case

@nh916 nh916 merged commit 12dd385 into main Sep 11, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants