Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: HTTP
DELETE
node #293Feature: HTTP
DELETE
node #293Changes from all commits
6a6ca71
c4d0d3f
688e296
125eedd
1531c0c
f91e467
0e910ab
53d7c36
cb4480d
421ddc7
0ae36d8
0498d84
6f6d6bd
2541d1e
df43358
a2edf83
791b473
5f3f50c
14c4692
1e38b22
e261ed4
a42d2d0
2c545d8
69cc8a2
7ae4cfe
980d5b8
3478647
7f504f3
0940e21
3e58dc1
1fabb5b
0bcaf7d
e15f0a4
ee9bfc9
c17df00
be23182
6663501
844cbab
5a01f5a
8c69cde
5dfd394
f699a93
a1fd669
55f71ef
54eb340
01d5cd4
76140de
baf1bb0
cf7fd43
3b413dd
9dc819e
b6fcdf3
37519a1
f5c8cb6
5349cb2
1cdfb21
95f0399
7857e7b
eb47dd2
9cefd2e
998dfcd
5fcdef5
7b2e0cb
22eb336
caea71f
3544320
3137cfd
4b4ae7c
96bc812
c1e3395
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the logic.
But would it be better to just send
delete
and handle the error from API if the node doesn't exist?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that could streamline the process, but the only thing that we would lose from that would be that we did not prove that the node was there before we went to delete it, so if we start getting bugs we might be asking ourselves,
"is it having issues because the API can't delete the node? or is it because the node never existed on the API?"
I was thinking that writing it this way could be a bit more explicit, but removing the first search would honestly not take away much as far as I can see and would be pretty easy too.
You think remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, I would insist on getting rid of it in production code, but this is tests only and should be OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would honestly be happy getting rid of it too either now or in a future PR. I think both should work and be okay