-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3-find-assets #96
v3-find-assets #96
Conversation
…elp developers run the samples
…set properties during upload, upload file as stream
Fixed merge conflicts |
Hi @ahongbynder I combined the last 2 remaining PRs into this one to avoid any more merge conflicts. I've closed v3-upload. Also, I noticed the samples did not cover the new ways of searching for assets, especially by metaproperty name and option. I created a new sample class called FindMediaSample for this. It searches in three ways:
The first 2 should always give the same number of results, the third one might yield more results because the word(s) you search for might occur in other properties as well of course. Also, I noticed one of the unit tests was failing. I fixed that as well, see last commit. |
…dictionaries, as they are used by multiple query classes
@quirijnslings Just have a couple minor comments. After merging before the release can be created, need to fix the github actions used in release process. Have reached out internally to look at it. |
@quirijnslings Merged in your changes, have this PR to fix GitHub actions and update dotnet version for tests #101. We have a release freeze next week so publishing your changes for V3 is dependent on the actions fixed and after our release freeze. |
Please merge v3-platform first
New features:
Test interactively with FindMediaSample, MediaSample and unit test with AssetServiceTest.