Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3-find-assets #96

Merged
merged 15 commits into from
Sep 20, 2024
Merged

Conversation

quirijnslings
Copy link
Contributor

@quirijnslings quirijnslings commented Sep 9, 2024

Please merge v3-platform first

New features:

  • Get full list of assets including count
  • Make it possible to find assets through a metaproperty query

Test interactively with FindMediaSample, MediaSample and unit test with AssetServiceTest.

@quirijnslings
Copy link
Contributor Author

Fixed merge conflicts

@quirijnslings
Copy link
Contributor Author

quirijnslings commented Sep 19, 2024

Hi @ahongbynder I combined the last 2 remaining PRs into this one to avoid any more merge conflicts. I've closed v3-upload.

Also, I noticed the samples did not cover the new ways of searching for assets, especially by metaproperty name and option. I created a new sample class called FindMediaSample for this. It searches in three ways:

  • By specifying the names of a meta property and meta property option
  • By specifying the ID of an option
  • Via keyword (basically plain text)

The first 2 should always give the same number of results, the third one might yield more results because the word(s) you search for might occur in other properties as well of course.

Also, I noticed one of the unit tests was failing. I fixed that as well, see last commit.

@ahongbynder
Copy link
Contributor

@quirijnslings Just have a couple minor comments. After merging before the release can be created, need to fix the github actions used in release process. Have reached out internally to look at it.

@ahongbynder ahongbynder merged commit 786c8dc into Bynder:master Sep 20, 2024
@ahongbynder
Copy link
Contributor

@quirijnslings Merged in your changes, have this PR to fix GitHub actions and update dotnet version for tests #101. We have a release freeze next week so publishing your changes for V3 is dependent on the actions fixed and after our release freeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants