Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Asset Service to use Stream instead of FileStream #104

Merged

Conversation

VGrigoriev1991
Copy link
Contributor

Simplified AssetService to use Stream instead of FileStream for file uploading since only the Stream base type is used further.

AssetService uses FileUploader for file uploading.
FileUploader expects Stream as first input parameter type when AssetService expects FileStream as first input parameter type.
AssetService doesn't use any features of the FileStream and can be simplified to use Stream as an first input parameter type.

This change should be useful in case of using Bynder SDK in clouds for serverless applications when there are limits on available disk space (for FileStream it's necessary to have file on the disk).

… uploading since only the Stream base type is used further
@coveralls
Copy link

Coverage Status

coverage: 53.518%. remained the same
when pulling 84f7091 on VGrigoriev1991:asset-service-upload-file-stream
into 0324ec6 on Bynder:master.

@ahongbynder ahongbynder merged commit 0b4872c into Bynder:master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants