Improve docroot resolver #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbosen
requested changes
Mar 20, 2017
src/Util/DocrootResolver.php
Outdated
|
|
||
| // Absolute paths are not supported. | ||
| $fileSystem = new Filesystem(); | ||
| if ($fileSystem->isAbsolutePath($composerBasePath)) { |
There was a problem hiding this comment.
absolute path should be possible as well
mtodor
force-pushed
the
feature/improve-docroot-resolver
branch
from
f501238 to
01cdc76
Compare
|
Btw, you could use https://github.com/webflo/drupal-finder to resolve the docroot. It supports various use-cases and configurations. |
|
@webflo that looks good, but as I see absolute (full) path is not supported. So I'll stay with current implementation. |
mtodor
force-pushed
the
feature/improve-docroot-resolver
branch
from
01cdc76 to
98c8b7f
Compare
|
@mtodor I think it would be better to improve drupal-finder then writing our own stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1.