-
Notifications
You must be signed in to change notification settings - Fork 38
Render author using a view mode specific template #162
base: 8.x-2.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need an update hook to install the view mode on existing sites. An example can be found in thunder_update_8006
@@ -0,0 +1 @@ | |||
<a>{{ content.field_forename|render|trim }} {{ content.field_surname|render|trim }}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no field_forename and field_surname fields in Thunder. Please use just the username
Why has this been closed? It's important. |
This was an automatic close from github, when the base branch was merged, please reopen it against the 8.x-1.x branch. |
@@ -0,0 +1 @@ | |||
<a>{{ user.displayName }}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use a new viewmode for the user, shouldn't we then also render the full user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is, that in the default configuration, the User entity doesn't have any name associated. Only a picture and "Member for" would be displayed.
Another option would be to keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need an update hook which imports the new configuration into the active configuration.
This should be done with 'config_update.config_update' service.
For examples on how to do this take a look here: https://github.com/BurdaMagazinOrg/thunder-distribution/blob/a84286911131c685173222378c79b7b59eb2e138/modules/thunder_media/thunder_media.install in function thunder_media_update_8102()
Please check the last commit. |
There are Coding Style issues. You can see them in the travis log https://travis-ci.org/BurdaMagazinOrg/thunder-distribution/jobs/199575911 |
No description provided.