This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
track sold out products INREL-3676 #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saviomuc
reviewed
Apr 17, 2018
| @@ -197,7 +197,8 @@ function infinite_preprocess_advertising_product(&$variables) { | |||
| ->setAttribute('data-price', $product->product_price->value) | |||
| ->setAttribute('data-currency', $product->product_currency->value) | |||
| ->setAttribute('data-uuid', $product->uuid->value) | |||
| ->setAttribute('data-product-id', $product->product_id->value); | |||
| ->setAttribute('data-product-id', $product->product_id->value) | |||
| ->setAttribute('data-sold-out', (string)$product->product_sold_out->value === "1" ? 'true' : 'false'); | |||
There was a problem hiding this comment.
How about we leave it clean without transforming the data? Something like: ->setAttribute('data-sold-out', (string)$product->product_sold_out->value
saviomuc
reviewed
Apr 17, 2018
| @@ -9,11 +9,6 @@ | |||
| initialize: function (pOptions) { | |||
| BaseView.prototype.initialize.call(this, pOptions); | |||
|
|
|||
| if (this.$el.hasClass('item-product--sold-out')) { | |||
There was a problem hiding this comment.
Not sure why this has to be removed. Can you clarify?
saviomuc
reviewed
Apr 17, 2018
| @@ -198,7 +193,8 @@ | |||
| brand: this.model.get('brand'), | |||
| provider: this.model.get('provider'), | |||
| productCategory: this.model.get('productCategory'), | |||
| containerType: this.model.get('containerType') || '' | |||
| containerType: this.model.get('containerType') || '', | |||
| soldOut: this.$el.attr('data-sold-out') === 'true' | |||
There was a problem hiding this comment.
Instead of getting the data here we could set the data on the model directly (and also transform data there):
this.model.set('sold-out', this.$el.data('sold-out') === 1 ? 'true' : 'false'). See Line 85.
There was a problem hiding this comment.
Afterwards it's just a simple soldOut: this.model.get('sold-out')
saviomuc
suggested changes
Apr 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.