Created a personal page for snook1.eth (0xeb50...) #34
Conversation
|
Someone is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thanks @NJarosz for your nice and tidy personal page!
As general advice if the repo provides a template for PR descriptions, it's best to use it. Additionally attach a picture (or in a more complex scenario a video) that makes it easier to understand what you want to implement.
Below you find small comments.
| import styles from "./styles.module.css"; | ||
| import type { NextPage } from "next"; | ||
|
|
||
| const Personal: NextPage = () => { |
There was a problem hiding this comment.
Since there are more personal pages, it would be nice to give it a more descriptive name.
| { href: "https://x.com/snook_eth", label: "X" }, | ||
| { href: "https://github.com/NJarosz", label: "GitHub" }, |
There was a problem hiding this comment.
You could create a social links array and move it outside the component to prevent unnecessary recreation on each render and to enhance readability.
|
@NJarosz do you want to complete this PR? Or should I close it? |
Fix #27
Created a page.tsx and directory for my address under the builders directory in the next.js app.
Also created a styles.modules.css file in that directory, as well as added a small .png for my avatar.