-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce signatures on post/patch operations #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll address all the comments besides the middleware and commit. I'll also open a new issue for the middleware improvement.
I made a few changes related to the comments I added before. Just merged into master a few hours before dogfooding, which is probably not recommendable, although it'd be awesome to show this feature today. @sogasg Could you please give it a run in your local before dogfooding? I checked everything works on my machine, but this things are mysterious some times, especially on live demos. In case things blow up, the commit master had as HEAD before merging was 2af7e33. Feel free to |
Thanks @dgrcode !! Just tested locally and everything seems to work. @sogasg Good luck at the dogfooding, let us know how it goes. |
Awesome work! Everything is working locally for me too :D |
Fixes #44
I worked on this with @dgrcode and I've just gave it the final touches.
This PR enforces the use of signatures on challenge / challenge review submissions. Not sure if we are missing something with the signatures, but I think this should be secure enough.
Let me know what you think.