Unfolding debug and approval conditions #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EmyrClement
commented
Oct 14, 2015
EmyrClement
commented
- Remove fakes before unfolding
- Add plot of fakes in visible phase space in produceUnfoldingHistograms for debug (fake histograms not used as calculated manually by RooUnfold)
- Script used to debug unfolding
- Script that calculates median and maximum uncertainty of a particular source across all bins of all variables
- Some plot cosmetics
- Fix assert bug - CHECK as odd it hasn't been noticed so far?
…dd TTJet yield after fake subtraction to output json.
… function that reads input errors to file_utilities.
…error for each category over all bins of all variables.
| @@ -27,7 +27,7 @@ def hist_to_value_error_tuplelist( hist ): | |||
| return zip( values, errors ) | |||
|
|
|||
| def values_and_errors_to_hist( values, errors, bins ): | |||
| assert( len( values ) == len( bins ) ) | |||
| assert( len( bins ) == len( values ) + 1 ) | |||
There was a problem hiding this comment.
I think bins means here bin edges. In which case we should rename it. Created issue #293 for this.
kreczko
added a commit
that referenced
this pull request
Oct 14, 2015
Unfolding debug and approval conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.