Merge pull request vassalengine#12886 from riverwanderer/suppress-pie…

…ce-pallettes-boolean-errors

Suppress piece palette boolean bad data errors

vassal-app/src/main/java/VASSAL/configure/PropertyExpression.java

@@ -2,6 +2,7 @@
 
 import VASSAL.build.BadDataReport;
 import VASSAL.build.module.properties.PropertySource;
+import VASSAL.counters.EditablePiece;
 import VASSAL.counters.GamePiece;
 import VASSAL.counters.PieceFilter;
 import VASSAL.i18n.Resources;
@@ -15,7 +16,7 @@
 
 /*
  * Class encapsulating a Property Match Expression
- * A PropertyExpression is it's own PieceFilter.
+ * A PropertyExpression is its own PieceFilter.
  */
 public class PropertyExpression implements PieceFilter {
 
@@ -120,7 +121,9 @@ public boolean isTrue(PropertySource ps, Auditable owner, AuditTrail audit) {
       result = expression.evaluate(ps, owner, audit);
     }
     catch (ExpressionException e) {
-      ErrorDialog.dataWarning(new BadDataReport(Resources.getString("Error.expression_error"),
+      // suppress error report if this is an editable piece on the Piece Palette (where boolean calcs are not supported)
+      if (!(owner instanceof EditablePiece) || ((EditablePiece) owner).getMap() != null)
+        ErrorDialog.dataWarning(new BadDataReport(Resources.getString("Error.expression_error"),
         "Expression=" + getExpression() + ", Error=" + e.getError(), e)); //NON-NLS
     }
     return "true".equals(result); //NON-NLS