[save-images] Add multithreaded version of save-images #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breakthrough
force-pushed
the
main
branch
2 times, most recently
from
85d1bdd to
2c55a55
Compare
Breakthrough
force-pushed
the
issue-450-save-images
branch
from
54c0a00 to
86b31aa
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Breakthrough
force-pushed
the
issue-450-save-images
branch
2 times, most recently
from
921f535 to
963a5dc
Compare
Breakthrough
force-pushed
the
issue-450-save-images
branch
from
963a5dc to
ce49341
Compare
Breakthrough
force-pushed
the
issue-450-save-images
branch
2 times, most recently
from
bb2bbff to
15e5aab
Compare
Breakthrough
force-pushed
the
issue-450-save-images
branch
from
15e5aab to
9575685
Compare
This improves performance by over 50% in some cases. This should also fix #450 since we use the Path module for files now instead of OpenCV's imwrite.
The save_images function was getting quite complex and difficult to maintain, especially with the multithreaded version. This breaks it out into an object with smaller functions. The existing save_images function can be implemented using this new object.
Ensure errors are re-raised safely from worker threads by using non-blocking puts and monitoring a common error queue.
Breakthrough
force-pushed
the
issue-450-save-images
branch
from
9575685 to
55dec7f
Compare
Breakthrough
force-pushed
the
issue-450-save-images
branch
from
4e7dfe7 to
a9f012e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance by over 50% in some cases.
Open tasks:
scenedetect.scene_managermodule has grown quite large and is mostly full of post-processing functionality) Move Post-Processing Functionality into Dedicated Submodule #463