-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2316] Updated native SDK and exposed new methods #164
Open
nsingh-branch
wants to merge
14
commits into
master
Choose a base branch
from
SDK-2316-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2316 -- .net maui update underlying native SDKs
Summary
Updated the Android and iOS SDKs to the latest versions, exposed the new DMA method, and updated the testbed to improve testing.
All of the code/file changes in the
BranchSDK.xcframework
can be ignored since that's just the new imported iOS SDK. Also theBranchSDK.iOSBinding/ApiDefinitions.cs
contains a lot of diffs from code being re-ordered, but also contains the update for th new method. The rest of the files should include the relevant, manual code changes.Motivation
Update the native SDK's to support the new DMA method and support the identity deprecation.
Type Of Change
Testing Instructions
Run the Timber testbed and check that all of the methods and requests look correct.
cc @BranchMetrics/saas-sdk-devs for visibility.